Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Panel.fit parameters #3192

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

darrenburns
Copy link
Member

This was such a quick fix that while triaging I thought I may as well just fix it.

Fixes #3142.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aabfd16) 98.30% compared to head (a31eefd) 98.28%.
Report is 25 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3192      +/-   ##
==========================================
- Coverage   98.30%   98.28%   -0.03%     
==========================================
  Files          74       74              
  Lines        8038     8044       +6     
==========================================
+ Hits         7902     7906       +4     
- Misses        136      138       +2     
Flag Coverage Δ
unittests 98.28% <92.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
rich/align.py 100.00% <ø> (ø)
rich/console.py 98.04% <100.00%> (+<0.01%) ⬆️
rich/markdown.py 99.45% <100.00%> (ø)
rich/panel.py 98.29% <ø> (ø)
rich/progress.py 92.92% <ø> (ø)
rich/syntax.py 98.19% <100.00%> (-0.29%) ⬇️
rich/text.py 99.01% <66.66%> (-0.17%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darrenburns darrenburns merged commit b97abfc into master Nov 7, 2023
22 checks passed
@darrenburns darrenburns deleted the add-missing-panel-fit-params branch November 7, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Panel.fit forgot height and highlight parameters
3 participants